Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct out-of-date reference to Python file #28085

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

frreiss
Copy link
Contributor

@frreiss frreiss commented Apr 23, 2019

The C++ function GraphToFunctionDef is the the core of the C API entry points TF_GraphToFunction and TF_GraphToFunctionWithControlOutputs. This function is actually a port of a Python function, and there is a comment above the function definition with a pointer to the original Python source. Unfortunately the Python code to which the comment refers has moved. I lost several hours of productivity figuring out that there is a Python function that does the same thing as GraphToFunctionDef.

This PR corrects the C++ source code comment to point to the correct Python file and Python function.

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Apr 23, 2019
Copy link
Contributor

@dynamicwebpaige dynamicwebpaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for enhancing the documentation!

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 23, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 23, 2019
@gbaned gbaned self-assigned this Apr 24, 2019
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 24, 2019
@tensorflow-copybara tensorflow-copybara merged commit 9741362 into tensorflow:master Apr 24, 2019
PR Queue automation moved this from Assigned Reviewer to Merged Apr 24, 2019
tensorflow-copybara pushed a commit that referenced this pull request Apr 24, 2019
@frreiss frreiss deleted the issue-py-file-loc branch May 9, 2019 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants